fix(cli): improve formatting for unknown message types and JSON content #4740
Conversation
- Add robust JSON parsing in CI mode with proper error handling - Distinguish between JSON objects/arrays (metadata) and plain text (content) - Enhance unknown message type handling in interactive mode - Add comprehensive test coverage (80+ test cases) - Handle edge cases: malformed JSON, empty values, nested structures - Ensure backward compatibility with existing message types
🦋 Changeset detectedLatest commit: 0fbe56f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // Try to parse JSON content for better display | ||
| let displayContent = message.text || `Unknown say type: ${message.say}` | ||
|
|
||
| // If text looks like JSON, try to format it nicely |
There was a problem hiding this comment.
This condition is inconsistent with AskMessageRouter.tsx line 34 which correctly uses parentheses. Due to operator precedence (&& binds tighter than ||), this evaluates as (message.text && message.text.trim().startsWith("{")) || message.text?.trim().startsWith("[") which happens to work but is harder to read and maintain.
| // If text looks like JSON, try to format it nicely | |
| if (message.text && (message.text.trim().startsWith("{") || message.text.trim().startsWith("["))) { |
|
| Severity | Issue | Location |
|---|---|---|
| WARNING | Operator precedence issue - missing parentheses for consistency with AskMessageRouter.tsx | cli/src/ui/messages/extension/SayMessageRouter.tsx:39 |
Recommendation: Address the warning before merge for code consistency.
Review Details (7 files)
Files reviewed:
.changeset/cli-formatting-fix.md(new file - changeset)cli/src/ui/messages/extension/AskMessageRouter.tsx(1 issue pattern reference)cli/src/ui/messages/extension/ExtensionMessageRow.tsx(no issues)cli/src/ui/messages/extension/SayMessageRouter.tsx(1 issue)cli/src/ui/messages/extension/__tests__/UnknownMessageType.test.tsx(new test file)cli/src/ui/utils/__tests__/jsonOutput.test.ts(new test file)cli/src/ui/utils/jsonOutput.ts(no issues)
Checked: Security, bugs, code consistency, error handling
Problem
This PR fixes CLI formatting issues identified in the analysis where unknown message types and JSON content were not being properly handled in both CI mode and interactive terminal mode.
Solution
1. Improved JSON parsing in CI mode (
jsonOutput.ts)metadatafield) and plain text (placed incontentfield)2. Enhanced unknown message type handling (interactive mode)
ExtensionMessageRow: Now displays message text for unknown typesDefaultAskMessage&DefaultSayMessage: Exported and improved to format JSON content nicely3. Comprehensive test coverage
jsonOutput.test.tswith 50+ test cases covering:UnknownMessageType.test.tsxwith 30+ test cases covering:Edge Cases Handled
Testing
Backward Compatibility
Related Issue
Fixes the CLI formatting issue identified in the earlier analysis.
Checklist