-
-
Notifications
You must be signed in to change notification settings - Fork 672
fix: direct typing #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: direct typing #493
Conversation
|
Hey @johnmalek312 could you give my updates to this PR a check and see if it works for you? Mainly I wanted to refactor all of the Linux support, both for direct typing as well as for simulating key presses. I'm probably going to bring in some more Linux testers after you confirm, if you're able, just to make sure we can give this build a try and hopefully solve a fair deal of the Linux input issues. I think in the future we might even want to add UI to the application to suggest to install certain utilities on Linux to make sure that paste works properly generally and broadly across the application. This would be pre-1.0.0 requirement |
|
Will test in 40min |
🧪 Test Build ReadyBuild artifacts for PR #493 are available for testing. Download artifacts from workflow run Artifacts expire after 30 days. |
|
Pinging some Linux testers. If you could make sure that 'pasting' works properly that would be massively helpful. Both the 'direct' method and 'ctrl+v' or similar methods there. If you are a wayland user and have @BerthalonLucas Please check out the test build above. I hope that this PR when complete will have at least some workaround for most Linux users to ensure paste generally works. Especially if specified tools are installed on the system. |
|
I am on x11, with xdotool: Ig this is standard behaviour. so its working. |
|
Thanks @johnmalek312 that is great news. Would be especially curious if the other folks I've pinged have the similar results on X11/Wayland as well. If so let's go. Thank you! |
|
I tried to test this, but I'm not sure that I'm running the right version. I first tried to build the entire project (successfully!) which involved cloning the current repo + building it. That ran although it then occurred to me that this PR hasn't been merged in yet so I wouldn't see the fix even if I got it to run. Next I noticed the "Test Build Ready" entry, above (duh 😁), downloaded that an installed it. I ran Handy via my Start menu (Whisker menu? I forget what XUbuntu calls it). I think this should be the new, test install because I didn't have it installed before, but honestly I'm not sure. For me the bug is still happening (again, keep in mind I might be running the wrong version). Repro steps I followed:
Is there a walkthrough for how I can make sure that I'm running the test version? P.S. When I tried pasting stuff into LibreWriter (direct method) it worked great the first time, but the second time it seemed to be using menu options (it ended with an 'open file' dialog on screen and nothing pasted). I think that's a separate issue but I gotta go do other stuff on my TODO list :) |
|
@MikeTheGreat do you have the appropriate cmdline tool installed on your system?? xdotool, dotool, or wtype? This will only help if you have the appropriate one installed |
|
Works for me, both direct and clipboard modes. KDE Plasma 6.5.4 (Wayland) on Arch Linux. Using dotool. I tested the AppImage. |

fixes #439 by using xdotool if available